Use modern ES syntax rather than .call
#29368
Merged
+34
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
previously approved these changes
Feb 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29368 +/- ##
==========================================
+ Coverage 85.01% 85.10% +0.08%
==========================================
Files 1059 1062 +3
Lines 28277 28352 +75
Branches 4538 4548 +10
==========================================
+ Hits 24040 24129 +89
+ Misses 3074 3061 -13
+ Partials 1163 1162 -1 ☔ View full report in Codecov by Sentry. |
ClearlyClaire
requested changes
Feb 23, 2024
|
This pull request has merge conflicts that must be resolved before it can be merged. |
renchap
force-pushed
the
modern-es-call
branch
from
8b9dd92
to
e84b1e7
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
ClearlyClaire
requested changes
Feb 27, 2024
ClearlyClaire
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Looks good now, although I'd like to see it run with the test introduced in #29424 first.
renchap
force-pushed
the
modern-es-call
branch
from
e79926f
to
880830e
Compare
|
Rebased to include your new test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced
Object.prototype.hasOwnProperty.callwith the new ES2022Object.hasOwn.It is not transpiled by Babel in the final files, because this function is supported by all the browsers our BrowsersList is targetting.
If this causes issues, then we can change our supported browsers list and target earlier versions, then it will be polyfilled accordingly.