Update dependency rubocop-rails to v2.24.0 - autoclosed #29495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
added
dependencies
mjankowski
approved these changes
Mar 5, 2024
renovate
bot
force-pushed
the
renovate/rubocop-rails-2.x-lockfile
branch
from
e61f00c
to
abe2fc4
Compare
|
This PR also bumps the i18n gem in addition to rubocop-rails. The CI failure here seems related to this feature added in i18n 1.14.3 - ruby-i18n/i18n#678 My guess is we are using one or more of the reserved keys - https://github.com/fatkodima/i18n/blob/7cf09474b77fd41e65d979134b0525f67cf371b0/lib/i18n.rb#L19-L33 - in an interpolation somewhere. We can probably either a) track down and change whatever those are (probably a good idea!) before updating i18n and let this PR rebase, b) update rubocop-rails in a way that doesnt bump i18n as well, if possible. |
|
Actually, I think the error in the CI failure is coming from the i18n-tasks gem itself, and not anything in the app. Opened glebm/i18n-tasks#552 |
renovate
bot
changed the title
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/rubocop-rails-2.x-lockfile
branch
from
abe2fc4
to
b6cf50b
Compare
renovate
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.23.1->2.24.0Release Notes
rubocop/rubocop-rails (rubocop-rails)
v2.24.0Compare Source
New features
Bug fixes
Rails/FindBywhen using multi-line leading dot method calls. ([@ymap][])Rails/WhereExistswithEnforcedStyle: whereand implicit receivers. ([@earlopain][])Changes
Rails/EnvironmentVariableAccessaware of initializers. ([@markokajzer][])object_idfromRails/DangerousColumnNamestargets. ([@r7kamura][])Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.