Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domain information to profiles in web UI #29602

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Add domain information to profiles in web UI #29602

merged 3 commits into from
Mar 15, 2024

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Mar 14, 2024

Peek.2024-03-14.19-37.mp4

@Gargron Gargron added the ui Front-end, design label Mar 14, 2024
@shleeable
Copy link
Contributor

shleeable commented Mar 15, 2024 •
edited

Please consider clicking the username copy the full path to the clipboard on the handle.

Being able to quickly copy/paste peoples full URLs is a repeatable pattern.

@ClearlyClaire
Copy link
Contributor

I like this a lot! My only concerns are:

  • I'm afraid that by making the @username@domain syntax less apparent, it will just be more confusing in the compose box
  • how to copy the handle is now less obvious (and one more click), and I'm afraid people will accidentally share the username alone more; maybe this last part could be improved by having an invisible @domain span so that clicking to select then copy will also copy the domain name

@Gargron @ClearlyClaire
Update app/javascript/mastodon/features/account/components/header.jsx
d1f5d28 
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
@Gargron @ClearlyClaire
Update app/javascript/mastodon/features/account/components/header.jsx
f43b045 
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
@Gargron Gargron added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 4072875 Mar 15, 2024
45 of 46 checks passed
@Gargron Gargron deleted the feature-domain-pills branch March 15, 2024 13:14
nileane added a commit to nileane/TangerineUI-for-Mastodon that referenced this pull request Mar 15, 2024
@nileane
Support for the new domain information dialog in profiles (mastodon/m…
c2c919f 
…astodon#29602)
lutoma pushed a commit to ohaisocial/mastodon that referenced this pull request Mar 19, 2024
@Gargron @ClearlyClaire @lutoma
Add domain information to profiles in web UI (mastodon#29602)
6cb2446 
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
ui Front-end, design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gargron @shleeable @ClearlyClaire