Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change design of notification about lost connections in web UI #29731

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Mar 24, 2024

grafik

@Gargron Gargron added the ui Front-end, design label Mar 24, 2024
@renchap renchap requested a review from a team March 24, 2024 11:51
@digitalcircuit
Copy link

digitalcircuit commented Mar 24, 2024

The newer message seems more clear and easier to understand!

That said, I am unsure if "An admin" could be confusing since moderators can block/suspend, too. Though I get that "a moderator" doesn't shorten down as nicely ("a mod" could sound like a browser/etc modification), and this distinction might not matter in practice.

(Regardless, even as someone running a single-user instance, I am immensely happy to see the overall feature making it into v4.3.0.)

Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording is an improvement, and so is the overall design, but it does not really fit with our other notification designs, because of the much larger padding, the larger icon, and the fact that everything is padded right:
image

Shouldn't it use the same padding and icon size as the other notifications (while possibly changing all of them in a future PR)?
image

@Gargron
Copy link
Member Author

Gargron commented Mar 25, 2024

I think that the uniqueness of this notification makes it possible to have it use the new design first. As a second step I would update all other non-mention notifications to have the new design.

Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the insistence for introducing the design inconsistency, but it's not a big deal. Looks good to me otherwise, and the wording is a clear improvement.

@Gargron Gargron added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit 29f9dc7 Mar 25, 2024
56 checks passed
@Gargron Gargron deleted the fix-design-relationships-severance-event branch March 25, 2024 13:32
cheeaun added a commit to cheeaun/phanpy that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants