Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency browser to v6 #30134

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 30, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
browser (changelog) 5.3.1 -> 6.0.0 age adoption passing confidence

Release Notes

fnando/browser (browser)

v6.0.0

Compare Source

  • Add Browser::Base#chromium_based?.
  • Change how browser detection works to avoid re-instantiating classes.
  • Bump up minimum required ruby version to 3.2.0.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Apr 30, 2024
@mjankowski
Copy link
Contributor

This is failing in our 3.1 matrix because there's a ruby 3.2+ requirement in this browser version bump. We may want to restrict version to < 6 until ruby 3.1 is EOL, or just ignore this update.

@ClearlyClaire
Copy link
Contributor

Yeah, I don't think we want to drop support for Ruby 3.1 anytime soon (as a side note I've been bitten by us dropping support for Ruby 3.0 as I was using system Ruby on an ArchLinux box and I did not notice they were still on Ruby 3.0).

@renovate renovate bot changed the title Update dependency browser to v6 chore(deps): update dependency browser to v6 May 13, 2024
@mjankowski
Copy link
Contributor

Opened issue fnando/browser#543

We should lock to < 6 if no reply there for a while, and then remove that some time in early 2025, when (presumably) ruby 3.1 is EOL'd.

@mjankowski
Copy link
Contributor

No response on linked issue from browser maintainer ... will open separate PR to lock us to < 6

@renovate renovate bot force-pushed the renovate/browser-6.x-lockfile branch from b2aa4c9 to 96f8d33 Compare June 25, 2024 17:45
@mjankowski
Copy link
Contributor

Closing in favour of #30766

@mjankowski mjankowski closed this Jun 25, 2024
Copy link
Contributor Author

renovate bot commented Jun 25, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 6.x releases. But if you manually upgrade to 6.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/browser-6.x-lockfile branch June 25, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants