Raise exceptions on unpermitted parameters errors in test environment #30377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2024
mjankowski
force-pushed
the
enable-test-env-raise-unpermitted
branch
2 times, most recently
from
b2e7b7f
to
795b359
Compare
mjankowski
force-pushed
the
enable-test-env-raise-unpermitted
branch
from
795b359
to
1557458
Compare
This was referenced Jun 14, 2024
mjankowski
force-pushed
the
enable-test-env-raise-unpermitted
branch
from
1557458
to
46b6a1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default here is
:logfor all envs - which means right now in the logs during local dev, spec runs, etc - there are various areas where we have params issues and they sort of just silently go by in the log without more attention called to them.This PR is going to fail CI, and I'm going to open up some follow-up PRs linking back to this with the various changes needed to enable this setting for test env. If we get them all in, I'll rebase this and we can contemplate merge for the setting itself.