Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exclusion for Rails/LexicallyScopedActionFilter cop #30697

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Remove exclusion for Rails/LexicallyScopedActionFilter cop #30697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .rubocop/rails.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ Rails/FilePath:
Rails/HttpStatus:
EnforcedStyle: numeric

Rails/LexicallyScopedActionFilter:
Exclude:
- app/controllers/auth/* # Conflicts with `Lint/UselessMethodDefinition` for inherited controller actions

Rails/NegateInclude:
Enabled: false

Expand Down
8 changes: 8 additions & 0 deletions app/controllers/auth/registrations_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,14 @@
super(&:build_invite_request)
end

def edit # rubocop:disable Lint/UselessMethodDefinition
super

Check warning on line 29 in app/controllers/auth/registrations_controller.rb

View check run for this annotation

Codecov / codecov/patch

app/controllers/auth/registrations_controller.rb#L29 

Added line #L29 was not covered by tests
end

def create # rubocop:disable Lint/UselessMethodDefinition
super

Check warning on line 33 in app/controllers/auth/registrations_controller.rb

View check run for this annotation

Codecov / codecov/patch

app/controllers/auth/registrations_controller.rb#L33 

Added line #L33 was not covered by tests
end

def update
super do |resource|
resource.clear_other_sessions(current_session.session_id) if resource.saved_change_to_encrypted_password?
Expand Down