Do not try to re-subscribe to unsubscribed accounts #4653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, looks good. Now we need to subscribe manually to recover subscription (e.g. in case of remote server had been down for half a month). I think it is reasonable, but we can consider admin tools for this at some time. For example: filter by subscription status, automatic unsubscribing logs, etc. |
unarist
reviewed
Aug 21, 2017
| end | ||
|
|
||
| def subscription(webhook_url) | ||
| OStatus2::Subscription.new(remote_url, secret: secret, lease_seconds: 30.days.seconds, webhook: webhook_url, hub: hub_url) | ||
| @subscription ||= OStatus2::Subscription.new(remote_url, secret: secret, webhook: webhook_url, hub: hub_url) |
There was a problem hiding this comment.
Is lease_seconds no longer needed?
There was a problem hiding this comment.
I removed it because it would confuse readers. The subscribe/unsubscribe methods of OStatus2::Subscription are no longer used anywhere. SubscribeService defines its own lease_seconds.
unarist
approved these changes
Aug 21, 2017
abcang
pushed a commit
to pixiv/mastodon
that referenced
this pull request
Aug 22, 2017
lindwurm
pushed a commit
to akane-blue/mastodon
that referenced
this pull request
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.