If HTTP signature is wrong and webfinger cache is stale, retry with resolve #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esolve If the signature could not be verified and the webfinger of the account was last retrieved longer than the cache period, try re-resolving the account and then attempting to verify the signature again
Gargron
added
activitypub
ClearlyClaire
requested changes
Sep 28, 2017
There was a problem hiding this comment.
While it doesn't look wrong to me, I fail to see what it solves. Indeed, account_from_key_id already updates remote data (provided old enough last_webfingered_at) by calling ResolveRemoteAccount.
On a side note, I have noticed the following files include SignatureVerification without seemingly using it:
app/controllers/accounts_controller.rbapp/controllers/stream_entries_controller.rb
|
@ThibG Uh no, account_from_key_id only calls ResolveRemoteAccountService for OStatus keyId format which is not used by Mastodon anymore. |
ClearlyClaire
approved these changes
Sep 28, 2017
rutan
pushed a commit
to rutan/mastodon
that referenced
this pull request
Oct 11, 2017
…esolve (mastodon#5129) If the signature could not be verified and the webfinger of the account was last retrieved longer than the cache period, try re-resolving the account and then attempting to verify the signature again
cobodo
pushed a commit
to cobodo/mastodon
that referenced
this pull request
Oct 20, 2017
…esolve (mastodon#5129) If the signature could not be verified and the webfinger of the account was last retrieved longer than the cache period, try re-resolving the account and then attempting to verify the signature again
abcang
pushed a commit
to pixiv/mastodon
that referenced
this pull request
Oct 12, 2018
…esolve (mastodon#5129) If the signature could not be verified and the webfinger of the account was last retrieved longer than the cache period, try re-resolving the account and then attempting to verify the signature again
KScl
pushed a commit
to KScl/mastodon
that referenced
this pull request
Dec 4, 2019
…esolve (mastodon#5129) If the signature could not be verified and the webfinger of the account was last retrieved longer than the cache period, try re-resolving the account and then attempting to verify the signature again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the signature could not be verified and the webfinger of the account was last retrieved longer than the cache period, try re-resolving the account and then attempting to verify the signature again