Show confirmation dialog on leaving WebUI while composing #5616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Back button and Back hotkey can cause leaving from WebUI, as well as browser's back button. Users may hit those buttons accidentally, and their composing text will be lost. So this prevents it by showing confirmation dialog from `onbeforeunload` event.
Gargron
reviewed
Nov 7, 2017
|
|
||
| // Dummy import, to make sure that <Status /> ends up in the application bundle. | ||
| // Without this it ends up in ~8 very commonly used bundles. | ||
| import '../../components/status'; | ||
|
|
||
| const messages = defineMessages({ | ||
| beforeUnload: { id: 'ui.beforeunload', defaultMessage: 'Your composing text will be lost by leaving from Mastodon.' }, |
There was a problem hiding this comment.
"Your draft will be lost if you leave Mastodon" sounds better
|
Isn't the bigger problem when you click "reply" or something else that clears the text area? shouldn't we show the warning then? |
|
@nightpool Ah yes, definitely. I think it can be a different PR because it would have different warning text with our confirmation modal. |
|
Sounds good
…On Wed, Nov 8, 2017 at 11:05 PM unarist ***@***.***> wrote:
@nightpool <https://github.com/nightpool> Ah yes, definitely. I think it
can be a different PR because it would have different warning text with our
confirmation modal.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5616 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAORV2Un3_Eq0ur6FX-aFjZbCd-c1zNaks5s0noigaJpZM4QVEMV>
.
|
Gargron
approved these changes
Nov 9, 2017
Gargron
pushed a commit
that referenced
this pull request
Nov 25, 2017
cobodo
pushed a commit
to cobodo/mastodon
that referenced
this pull request
Dec 6, 2017
) * Show confirmation dialog on leaving WebUI while composing Currently, Back button and Back hotkey can cause leaving from WebUI, as well as browser's back button. Users may hit those buttons accidentally, and their composing text will be lost. So this prevents it by showing confirmation dialog from `onbeforeunload` event. * Fix message and comments
cobodo
pushed a commit
to cobodo/mastodon
that referenced
this pull request
Dec 6, 2017
* yarn manage:translations * Add Japanese translation for mastodon#5087 * Add Japanese translation for mastodon#5616 * Add Japanese translation for mastodon#5746 * Add Japanese translation for mastodon#5750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Back button and Back hotkey can cause leaving from WebUI, as well as browser's back button. Users may hit those buttons accidentally, and their composing text will be lost.
So this prevents it by showing confirmation dialog from
onbeforeunloadevent.Thoughts:
returnValueis only used on Edge. So maybe we can put simple text or blank string.onbeforeunloadcan also mitigate Remain in app UI when clicking back button on a column #946 Redirect to unexpected page #3515, but I don't think it's good because 1) this may not work on mobile and some cases 2) I think it should back to Getting Started or simply ignore instead of unwanted dialog.