Do not filter the status collection after muting and blocking #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Nov 25, 2017
Gargron
reviewed
Nov 25, 2017
| @@ -139,9 +127,6 @@ export default function statuses(state = initialState, action) { | |||
| return normalizeStatuses(state, action.statuses); | |||
| case TIMELINE_DELETE: | |||
| return deleteStatus(state, action.id, action.references); | |||
| case ACCOUNT_BLOCK_SUCCESS: | |||
There was a problem hiding this comment.
You need to remove these from imports too (CodeClimate)
ykzts
previously requested changes
Nov 25, 2017
There was a problem hiding this comment.
https://github.com/tootsuite/mastodon/pull/5815/files#diff-cc35b0b54a87d744fce947f1209592a0R25
It is not used. Please delete it.
Filtering the status collection wipes out even the profiles of muted and blocked accounts. However, the behavior is inconsistent with the server- side behavior.
akihikodaki
force-pushed
the
filter_contexts
branch
from
01f40b2
to
b448e6d
Compare
|
b448e6d applies #5815 (review). |
cobodo
pushed a commit
to cobodo/mastodon
that referenced
this pull request
Dec 6, 2017
…on#5815) Filtering the status collection wipes out even the profiles of muted and blocked accounts. However, the behavior is inconsistent with the server- side behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering the status collection wipes out even the profiles of muted and blocked accounts. However, the behavior is inconsistent with the server-side behavior.
This resolves #5469.