Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview image to photo preview cards #5957

Closed
wants to merge 1 commit into from

Conversation

akihikodaki
Copy link
Contributor

The below is a screenshot of a preview of one media attachment (left) and one embedded photo (right). Note that the preview is only shown after a card is loaded.
screen shot 2017-12-10 at 16 11 14

@akihikodaki
Copy link
Contributor Author

I would like to include this change to v2.1 because it already has another change for preview_cards table. (#5775).
The migration task mastodon:maintenance:migrate_photo_preview_cards can deal with those two changes at once.
cc: @Gargron

@Gargron
Copy link
Member

Gargron commented Dec 12, 2017

After

If card is simply included in status and we ensure FetchLinkCardService happens before or during distribution, we won't need a separate real-time delivery mechanism for link cards.

is solved, this will be a nice change. But I think it's not needed right now because

Note that the preview is only shown after a card is loaded.

And that would be a slightly confusing UI "jump" for users.

@akihikodaki
Copy link
Contributor Author

@Gargron

And that would be a slightly confusing UI "jump" for users.

I see. What about applying only the change for database?

@Gargron
Copy link
Member

Gargron commented Dec 12, 2017

What about applying only the change for database?

Okay, that is fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants