New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid OEmbed if response does not respond to url #5988

Merged

Gargron merged 1 commit into mastodon:master from masto-donte-com-br:bugfix/undefined_url_on_oembed

Dec 12, 2017

Contributor

renatolond commented Dec 12, 2017

Avoid error when the url returns a mostly valid oembed, but has no url in it, causing a MethodError: undefined method `url' for #OEmbed::Response::Photo:0x000056505def9620.
This was happening with a link from Derpibooru tagged with NSFW content.


          Return false if object does not respond to url

Avoid error when the service returns a mostly valid oembed, but has no
url in it, causing a MethodError: undefined method `url'
for #<OEmbed::Response::Photo:0x000056505def9620>

ykzts approved these changes

View reviewed changes

ykzts added the bug label

Gargron merged commit 19257d9 into mastodon:master

renatolond deleted the bugfix/undefined_url_on_oembed branch

January 22, 2018 13:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment