Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid OEmbed if response does not respond to url #5988

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Avoid OEmbed if response does not respond to url #5988

merged 1 commit into from
Dec 12, 2017

Commits on Dec 12, 2017

  1. Return false if object does not respond to url 

    Avoid error when the service returns a mostly valid oembed, but has no
url in it, causing a MethodError: undefined method `url'
for #<OEmbed::Response::Photo:0x000056505def9620>
    @renatolond
    renatolond committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    5568194 View commit details
    Browse the repository at this point in the history