Make detect empty string before assign image description #5994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to delete image description text, a bug occurred.
see following vid:
this case, even if I'm pressing delete key, the text will re-appear when trying to delete the last character. and this PR fixes it, here's the bug reason:
handleInputChange()
and it setse.target.value
tothis.state.dirtyDescription
description
will bethis.state.dirtyDescription
ormedia.get('description')
or an empty stringthis.state.dirtyDescription
will benull
, sodescription
becomesmedia.get('description')
media.get('description')
still holds description that before I try to delete it.So it needs to detect whether
this.state.dirtyDescription
isnull
or just an empty string.