Fix overflowing emojis on some devices #6016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
requested changes
Dec 13, 2017
| @@ -604,7 +604,7 @@ | |||
| line-height: 20px; | |||
| word-wrap: break-word; | |||
| font-weight: 400; | |||
| overflow: hidden; | |||
| overflow: visible; | |||
There was a problem hiding this comment.
This is a bad idea because this line was guarding against zalgo text going outside a single toot's area.
There was a problem hiding this comment.
I understand, but emojis have negative margin, it is difficult to display well in all unknown devices without space between status__info and status__content.
I update this pull request, add 2px space, like suggention 1 of #5474 (comment) .
Gargron
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find out some devices display images in paragraph a bit higher, I can't check all devices, so I set overflow as visible.