Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign tootbox #5919

Merged
merged 2 commits into from
Dec 13, 2017
Merged

Redesign tootbox #5919

merged 2 commits into from
Dec 13, 2017

Conversation

lynlynlynx
Copy link
Contributor

This is a suggestion.
This solves ellipsis of toot buttons in all languages whose translation is long.

There is much blank space under tootbox, so it's nice way to display toot button in all languages.
Another solution for #4736 , and all 4736's cons are solved.

Problem With this commit
image image

Suggestion by @mattcoxonline , thanks!

@lynlynlynx lynlynlynx added suggestion Feature suggestion ui Front-end, design labels Dec 7, 2017
@Sylvhem
Copy link
Contributor

Sylvhem commented Dec 10, 2017

I really like it. But why not put the characters counter inside the .compose-form__buttons DIV element rather than into the .compose-form__upload-button one while we are at it? It would make the first looks less empty. Just a thought.

@Gargron
Copy link
Member

Gargron commented Dec 11, 2017

I agree with @Sylvhem, it feels like the character counter should go into the grey bar to the right

@lynlynlynx
Copy link
Contributor Author

@Sylvhem Thanks! I also agree with you. I'm working on it.

@Gargron What should I do with the color settings? The colors in the screenshot below are #42485a lighten($ui-base-color, 12%) for the counter text, and #c2c2c2 lighten($simple-background-color, 24%) for the border(Is this needed?).

This is a test screenshot (under development).
working

@Gargron
Copy link
Member

Gargron commented Dec 11, 2017

@lynlynlynx Make the border a bit lighter and add more padding between the border and 500

Also... maybe... font-weight: 500 on the counter?

@mattcoxonline
Copy link

mattcoxonline commented Dec 11, 2017

screen shot 2017-12-11 at 18 52 25

I would suggest that the character count goes on the right hand side without any border. Roboto Bold, 14px, right aligned.

When it comes to colours, I picked out #434B5F - which I'd also set for the colour of the icons in that strip to. The existing colours don't really pass to a decent accessibility standard.

screen shot 2017-12-11 at 18 48 57

Change font and remove shadow
Refactor sass codes of compose-form
@Gargron Gargron merged commit 0aeec03 into mastodon:master Dec 13, 2017
@lynlynlynx
Copy link
Contributor Author

Thanks @mattcoxonline

Finally, compose-form looks like the screenshot below.
The contrast ratio of the counter text is 7.63 (AAA on WCAG 2.0).

image

Unfortunately, there are many button colors (default, hover, active, and disabled) and many of them are out of WCAG 2.0 guidelines. When it comes to change the colors, we need to discuss about all of them, so why don't we discuss on a new pull request?

@lynlynlynx lynlynlynx deleted the redesign-tootbox branch December 13, 2017 16:39
yi0713 added a commit to yi0713/mastodon that referenced this pull request Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Feature suggestion ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants