Federate custom emojis with accounts

[davefp]

Fixes #5666

This PR Adds an option to the simplified_format helper to render custom emoji.

It also adds this option to calls made from the REST account serializer and the account show partial.

Finally, there are unit tests for the new option.

I'm not familiar with the ins and outs of the various views and serializers, so if this PR puts code in the wrong place please let me know. Thanks!

[akihikodaki]

The idea sounds great, but this implementation does not federate, does it?

[davefp]

I don't know. I'm not familiar enough with the codebase to recognize which bits deal with federation vs. which don't. Can you expand on which bits are problematic?

[akihikodaki]

To federate:

• the sender should attach emojis
• the receiver should receive attached emojis

For instance, the sender implementation for statuses attaches emojis

• to note as tags for ActivityPub (see ActivityPub::NoteSerializer)
• to post object as links for OStatus (see OStatus::AtomSerializer)

The receiver implementation for statuses resolves emojis

• in Create object for ActivityPub (see ActivityPub::Activity::Create)
• in post object for OStatus (see OStatus::Activity::Creation)

Similar changes are required by:

• ActivityPub::ActorSerializer
• OStatus::AtomSerializer
• ActivityPub::ProcessAccountService
• UpdateRemoteProfileService

[davefp]

Thanks! I'll take a look at this in more detail over the weekend.

My concern seems addressed but I have not reviewed yet.

[davefp]

I also want to add tests and do a little refactoring, please do not merge yet :)

[Gargron]

This looks alright, I think, is it still WIP?

[davefp]

I was hoping to add some tests, but the functionality is all there.

…

On Sun, Apr 1, 2018, 06:14 Eugen Rochko, ***@***.***> wrote: This looks alright, I think, is it still WIP? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6124 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASNRVxsiUvVYotoH4AS1XvrGMJZ_nKgks5tkKiigaJpZM4ROm_2> .

[Gargron]

For reference, I think this is still missing the parts for rendering custom emojis within the web UI.