Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenGraph meta tag's translation error #6841

Closed

Conversation

mayaeh
Copy link
Contributor

@mayaeh mayaeh commented Mar 20, 2018

After #6818 , "translation missing" is displayed in og: description of OGP meta tag on toot direct link in untranslated language.
This PR will fix it.

before:
2

after:
3

@mayaeh
Copy link
Contributor Author

mayaeh commented Mar 20, 2018

Please wait for the merge yet.
I am looking at problems pointed out at Mastodon.

I corrected it and sent it.
Thank you for teaching.

@Gargron
Copy link
Member

Gargron commented Mar 20, 2018

Odd. It should definitely just fallback to the en locale in production?

@tateisu
Copy link
Contributor

tateisu commented Mar 20, 2018

if fall back to non-en language, it may reproduct missing translation. I think fallback to en is mandatory.

@ykzts ykzts added the i18n Internationalization and localization label Mar 20, 2018
@mayaeh
Copy link
Contributor Author

mayaeh commented Mar 20, 2018

Sorry, I chose this approach because I could not find any other way.
I thought en would be better than choosing a language that might not have a translation.

@Gargron
Copy link
Member

Gargron commented Mar 20, 2018

This code:

https://github.com/tootsuite/mastodon/blob/master/config/application.rb#L78-L83

Should've made sure than when the default locale is not English, missing translations still fallback to English. Why is it not working then?

@MitarashiDango
Copy link
Contributor

In my environment this phenomenon was reproduced.
Also, it was confirmed that DEFAULT_LOCALE of .env.production is affecting.
Is this the intended behavior?

@Gargron
Copy link
Member

Gargron commented Mar 20, 2018

Well...it is overwritten.

@akihikodaki aaaaaaaaaaaaaaa

@akihikodaki
Copy link
Contributor

akihikodaki commented Mar 20, 2018

I'm really sorry. Recently I had two bugs, including this, which cannot be reproduced on my development environment, but I think I could find out them before it gets merged if I was careful enough.

I'm preparing a fix and will submit shortly after.

@ineffyble
Copy link
Member

@mayaeh This issue was addressed by #6843 - are you happy to close?

@mayaeh
Copy link
Contributor Author

mayaeh commented Mar 20, 2018

Thank you for being taught.
I am also checking merging # 6843 in my environment.
Please let me close this after that running.

@mayaeh mayaeh closed this Mar 20, 2018
@mayaeh mayaeh deleted the fix_6818_ogp-translation-missing branch March 22, 2018 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization and localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants