-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenGraph meta tag's translation error #6841
Conversation
I corrected it and sent it. |
Odd. It should definitely just fallback to the |
if fall back to non-en language, it may reproduct missing translation. I think fallback to en is mandatory. |
Sorry, I chose this approach because I could not find any other way. |
This code: https://github.com/tootsuite/mastodon/blob/master/config/application.rb#L78-L83 Should've made sure than when the default locale is not English, missing translations still fallback to English. Why is it not working then? |
In my environment this phenomenon was reproduced. |
@akihikodaki aaaaaaaaaaaaaaa |
I'm really sorry. Recently I had two bugs, including this, which cannot be reproduced on my development environment, but I think I could find out them before it gets merged if I was careful enough. I'm preparing a fix and will submit shortly after. |
Thank you for being taught. |
After #6818 , "translation missing" is displayed in og: description of OGP meta tag on toot direct link in untranslated language.
This PR will fix it.
before:
after: