-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add white outline to black emojis (fix #5083) #7936
Conversation
Cool! :) |
0eb4eb4
to
0c2821b
Compare
Done. Let me know if there are any more. |
0c2821b
to
e3b431a
Compare
I personally think it's better to have it look better on most browsers, than have it hardly visible on all browsers, but if the general consensus is to remove the outline, I'm happy with that. |
Wouldn't it be better to apply a filter like |
Personally I don't think that will work. Some emojis won't make much sense
when you switch the black color with white. It's a nice suggestion
nonetheless.
…On Mon, 9 Jul 2018 at 01:48, trwnh ***@***.***> wrote:
Wouldn't it be better to apply a filter like invert(100%) instead of a
white outline? As long as the icons are greyscale, this shouldn't mess up
any colors. If it does, then you can apply a filter hue-rotate(180deg) as
well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7936 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABl2aJOUWgIVql4J35R2IqIp4OAECzzrks5uEqhXgaJpZM4VA8Fl>
.
|
This change adds a white outline to black emojis so they are visible while using the default theme. It also reduces their size slightly so that the outline does not leak out outside the container.
The list of black emojis can be easily updated by appending a string to a SASS variable.