Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white outline to black emojis (fix #5083) #7936

Merged
merged 1 commit into from
Jul 4, 2018

Conversation

MaciekBaron
Copy link
Contributor

This change adds a white outline to black emojis so they are visible while using the default theme. It also reduces their size slightly so that the outline does not leak out outside the container.

The list of black emojis can be easily updated by appending a string to a SASS variable.

image

@renatolond
Copy link
Contributor

renatolond commented Jul 3, 2018

Cool! :)
Maybe add it to spider and ant too?

@MaciekBaron
Copy link
Contributor Author

Done. Let me know if there are any more.

@ykzts ykzts added ui Front-end, design accessibility Screen readers and related labels Jul 4, 2018
@Gargron Gargron merged commit 0bfa0f2 into mastodon:master Jul 4, 2018
@Gargron
Copy link
Member

Gargron commented Jul 7, 2018

Unfortunately, it doesn't seem to look any good on Firefox (deployed on mastodon.social):

grafik

I would suggest a revert because this is visually worse than them just not showing up on a dark theme (fwiw discord and tweetdeck have the same problem and aren't doing anything to correct it either)

lawremipsum pushed a commit to lawremipsum/mspsocial-mastodon that referenced this pull request Jul 7, 2018
@MaciekBaron
Copy link
Contributor Author

I personally think it's better to have it look better on most browsers, than have it hardly visible on all browsers, but if the general consensus is to remove the outline, I'm happy with that.

@trwnh
Copy link
Member

trwnh commented Jul 9, 2018

Wouldn't it be better to apply a filter like invert(100%) instead of a white outline? As long as the icons are greyscale, this shouldn't mess up any colors. If it does, then you can apply a filter hue-rotate(180deg) as well.

@MaciekBaron
Copy link
Contributor Author

MaciekBaron commented Jul 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Screen readers and related ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants