Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve account bar css #8087

Merged
merged 3 commits into from
Jul 28, 2018
Merged

Conversation

ariasuni
Copy link
Contributor

@ariasuni ariasuni commented Jul 28, 2018

fix #8052

Before/after, when using a them/custom CSS with flexible columns:
screenshot_2018-07-28 mastodon dev before
screenshot_2018-07-28 mastodon dev after

Before/after, text alignment when using no custom CSS:
screenshot_2018-07-28 mastodon dev before 2
screenshot_2018-07-28 mastodon dev after 2

@Gargron
Copy link
Member

Gargron commented Jul 28, 2018

0px should be written without units as 0

border-right: 1px solid lighten($ui-base-color, 8%);
padding: 10px 5px;
padding: 10px 0px;
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> padding: 10px 0;

Remove px.

@nightpool
Copy link
Member

@chr-1x heads up re the issue we've been having on cybre

@Gargron Gargron merged commit 2ccef52 into mastodon:master Jul 28, 2018
kyori19 pushed a commit to kyori19/mastodon that referenced this pull request Sep 20, 2018
* Remove superfluous span tags

* Make account bar items (except dropdown) flexible to work well with custom CSS

* Fix CSS lint warning (0px → 0)
@ariasuni ariasuni deleted the improve-account-bar-css branch June 25, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account action bar doesn’t work well with flexible columns
4 participants