Add attachment list fallback to public pages #9780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6714
I'm not too familiar with HAML, so I'm not sure if the fallback-as-a-block pattern makes a lot of sense.
Also, the code for rendering the list should probably be moved into another fragment or a helper.
Looks like this when the JS part hasn't loaded yet / if it doesn't load:
![screenshot_2019-01-10 thib thib mastodev sitedethib com](https://user-images.githubusercontent.com/384364/50977027-a639f200-14f1-11e9-9ff7-4a139af890b7.png)