Add attachment list fallback to public pages #9780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something is not right in the screenshot. Spacing to the icon as well as the color of the icon. |
|
I think it should be possible to reuse the CSS of the AttachmentList component instead of redefining a copy. |
ClearlyClaire
force-pushed
the
features/public-nojs-fallback
branch
3 times, most recently
from
9d72364
to
e68fcbd
Compare
ClearlyClaire
force-pushed
the
features/public-nojs-fallback
branch
from
e68fcbd
to
2c4148b
Compare
|
Oops, updated it, it looks like this now: |
ykzts
approved these changes
Jan 12, 2019
ClearlyClaire
force-pushed
the
features/public-nojs-fallback
branch
from
8ff549b
to
23c4729
Compare
ClearlyClaire
force-pushed
the
features/public-nojs-fallback
branch
from
23c4729
to
34b0cab
Compare
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Add attachment list fallback to public pages Fixes mastodon#6714 * Refactor attachments lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6714
I'm not too familiar with HAML, so I'm not sure if the fallback-as-a-block pattern makes a lot of sense.
Also, the code for rendering the list should probably be moved into another fragment or a helper.
Looks like this when the JS part hasn't loaded yet / if it doesn't load:
