Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieving place photos #29

Open
sarbogast opened this issue Mar 9, 2023 · 1 comment
Open

Retrieving place photos #29

sarbogast opened this issue Mar 9, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@sarbogast
Copy link

Is there any particular reason why you return only the string value of photo attributions in metadata instead of the full link? Because according to Google Places rules, we are supposed to include a tappable link to those attributions when presenting the image.

Also, is there any particular reason why image is returned as an Image widget instead of directly as a Uint8List? If is was possible to get the raw image data, we could do something else with it, store it somewhere (but maybe that's against the ToS, I don't know), or build our own memory image with custom parameters (especially for fit).

@matanshukry
Copy link
Owner

Is there any particular reason why you return only the string value of photo attributions in metadata instead of the full link? Because according to Google Places rules, we are supposed to include a tappable link to those attributions when presenting the image.

We actually return both, or rather only one - the one that we get back.
On the web we get back url so we return it.
On android for example we get back a Bitmap, so we can't return an actual url - see Response

We also return the attribution as field, so you should be able to use that to get the full image url; no?

Also, is there any particular reason why image is returned as an Image widget instead of directly as a Uint8List? If is was possible to get the raw image data, we could do something else with it, store it somewhere (but maybe that's against the ToS, I don't know), or build our own memory image with custom parameters (especially for fit).

We can probably return that as Uint8List, make sense.

@matanshukry matanshukry added the enhancement New feature or request label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants