Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling :JABSOpen when there is already a JABS window opens another JABS window #9

Closed
zeertzjq opened this issue Jul 12, 2021 · 3 comments

Comments

@zeertzjq
Copy link

zeertzjq commented Jul 12, 2021

Calling :JABSOpen when there is already a JABS window opens another JABS window, and this can cause some weird effects. If :JABSOpen is called multiple times in a non-floating window, multiple JABS windows are opened in the same position. If :JABSOpen is called inside a JABS window (which can happen if a keybinding mapped to :JABSOpen is pressed multiple times), another JABS window is opened in a position one line and one column off from the original position.
Maybe :JABSOpen can be changed to something that toggles the JABS window (:JABSToggle)?

@zeertzjq zeertzjq changed the title Calling :JABSOpen when there is already a JABS window opens another window Calling :JABSOpen when there is already a JABS window opens another JABS window Jul 13, 2021
@zeertzjq zeertzjq reopened this Jul 13, 2021
@matbme
Copy link
Owner

matbme commented Aug 9, 2021

Hello! Just pushed a commit that addresses this problem to the bugfix branch. Could you configure your package manager to pull from it and test it out?

Maybe :JABSOpen can be changed to something that toggles the JABS window (:JABSToggle)?

In the future I might add a :JABSToggle command, but for now I kept :JABSOpen as the toggle command for compatibility.

@zeertzjq
Copy link
Author

zeertzjq commented Aug 9, 2021

It works. :JABSOpen toggles the buffer switcher.

@matbme
Copy link
Owner

matbme commented Aug 13, 2021

Great! Bugfix branch is now merged with Main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants