Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather still not fully sorted #33

Closed
NuxRo opened this issue Aug 29, 2016 · 14 comments
Closed

Weather still not fully sorted #33

NuxRo opened this issue Aug 29, 2016 · 14 comments

Comments

@NuxRo
Copy link

NuxRo commented Aug 29, 2016

Apparently forecasting is still broken, see this user's message
https://lists.centos.org/pipermail/centos/2016-August/160898.html

It's for Gnome2, but broken on MATE, too:

grep -Ri "weather.noaa" *
ChangeLog:    update weather.noaa.gov url
ChangeLog:    update weather.noaa.gov url
libmateweather/weather-metar.c: "GET", "http://weather.noaa.gov/mgetmetar.php",
libmateweather/weather-iwin.c:    url = g_strdup_printf ("http://weather.noaa.gov/pub/data/forecasts/zone/%s/%s.txt", state, zone);
@monsta
Copy link
Contributor

monsta commented Aug 29, 2016

This forecast seems to be for US only, so I can't test it (also - which app uses it?)

Anyway, I'd simply replace http://weather.noaa.gov/pub/data with http://tgftp.nws.noaa.gov/data (yes, there's no pub in URL). That server seems to have the same info.

@NuxRo
Copy link
Author

NuxRo commented Aug 29, 2016

This app http://tmp.nux.ro/JJ7-weatherapp.mp4

Will give your suggestion a go when I get the chance next.

@monsta
Copy link
Contributor

monsta commented Aug 30, 2016

Ah... so it's just the weather applet, I didn't realize it had the forecast tab there. That tab was never shown to me due to unsupported location (I'm in Russia).

@NuxRo
Copy link
Author

NuxRo commented Aug 31, 2016

Did what you suggested, it still doesn't work for London, but switched my location to New York and I could get some forecast.

Wonder what that http://weather.noaa.gov/mgetmetar.php is doing in weather-metar.c though and what stuff it breaks.

Would it be difficult to switch to YR.NO? They seem to cover much more locations.

@monsta
Copy link
Contributor

monsta commented Aug 31, 2016

Wonder what that http://weather.noaa.gov/mgetmetar.php is doing in weather-metar.c though and what stuff it breaks.

It's not there anymore after 835055e. Forecast-related code is in libmateweather/weather-iwin.c anyway.

Would it be difficult to switch to YR.NO? They seem to cover much more locations.

If anyone is willing to analyze the format of their data and make the necessary changes to the source code, I'm fine with it.

@monsta
Copy link
Contributor

monsta commented Aug 31, 2016

I see the guy at https://ubuntu-mate.community/t/weather-applets-inop/8435/43 claims the new forecast URL is working for him. I can't find which location he's in though.

@NuxRo
Copy link
Author

NuxRo commented Aug 31, 2016

Monsta, it works for USA locations at least, try to set your applet to some of their cities and it'll work with the fix you suggested (confirmed also by the ubuntu user).
It doesn't work for the rest of the world.

@monsta
Copy link
Contributor

monsta commented Aug 31, 2016

You mentioned it doesn't work for London - did it work with the old server?

@NuxRo
Copy link
Author

NuxRo commented Aug 31, 2016

I never checked, always used the BBC weather site for forecasting. I only looked into it because the other guy with Fedora 24 was complaining. :)

@monsta
Copy link
Contributor

monsta commented Aug 31, 2016

Ok, I'll wait for replies from guys from Ubuntu MATE community, maybe we'll get more test results.
However, I don't think there's much choice here... we're offered only one replacement server that can be used without changing too much code (like it would be with Norwegian provider or any others out there).

@NuxRo
Copy link
Author

NuxRo commented Aug 31, 2016

True, I think your suggested solution fixes this issue, let's close it and what will be will be.

@NuxRo NuxRo closed this as completed Aug 31, 2016
@monsta
Copy link
Contributor

monsta commented Aug 31, 2016

Wait, I didn't apply the patch yet in the repo 😄

@goetzc
Copy link
Contributor

goetzc commented Sep 4, 2016

Is this fix in some branch?

@monsta
Copy link
Contributor

monsta commented Sep 6, 2016

Now it is, in master and 1.14 (and version 1.14.3 is released).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants