Skip to content

Commit

Permalink
![ColorThemer] Reorganize source to create separate targets for each …
Browse files Browse the repository at this point in the history
…color themer. (#1466)

* reorganize the color themer classes so that they are separate targets for each mutator.

* moved source files out of MaterialThemes.

* moved theme examples into their main component locations out of themer’s.

* renamed core subspec to 'Component'
  • Loading branch information
randallli committed May 26, 2017
1 parent 3a57189 commit 1c7ca93
Show file tree
Hide file tree
Showing 12 changed files with 35 additions and 23 deletions.
49 changes: 31 additions & 18 deletions MaterialComponents.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -138,24 +138,40 @@ Pod::Spec.new do |s|
end

s.subspec "Dialogs" do |ss|
ss.ios.deployment_target = '8.0'
ss.public_header_files = "components/#{ss.base_name}/src/*.h"
ss.source_files = "components/#{ss.base_name}/src/*.{h,m}", "components/#{ss.base_name}/src/private/*.{h,m}"

ss.dependency "MaterialComponents/Buttons"
ss.dependency "MaterialComponents/ShadowElevations"
ss.dependency "MaterialComponents/ShadowLayer"
ss.dependency "MaterialComponents/private/KeyboardWatcher"
ss.dependency "MaterialComponents/private/RTL"
ss.subspec "Component" do |sss|
sss.ios.deployment_target = '8.0'
sss.public_header_files = "components/#{ss.base_name}/src/*.h"
sss.source_files = "components/#{ss.base_name}/src/*.{h,m}", "components/#{ss.base_name}/src/private/*.{h,m}"

sss.dependency "MaterialComponents/Buttons"
sss.dependency "MaterialComponents/ShadowElevations"
sss.dependency "MaterialComponents/ShadowLayer"
sss.dependency "MaterialComponents/private/KeyboardWatcher"
sss.dependency "MaterialComponents/private/RTL"
end
ss.subspec "ColorThemer" do |sss|
sss.ios.deployment_target = '8.0'
sss.public_header_files = "components/#{ss.base_name}/src/#{sss.base_name}/*.h"
sss.source_files = "components/#{ss.base_name}/src/#{sss.base_name}/*.{h,m}", "components/#{ss.base_name}/src/#{sss.base_name}/private/*.{h,m}"
sss.dependency "MaterialComponents/Themes"
end
end

s.subspec "FeatureHighlight" do |ss|
ss.ios.deployment_target = '8.0'
ss.public_header_files = "components/#{ss.base_name}/src/*.h"
ss.source_files = "components/#{ss.base_name}/src/*.{h,m}", "components/#{ss.base_name}/src/private/*.{h,m}"
ss.resources = ["components/#{ss.base_name}/src/Material#{ss.base_name}.bundle"]
ss.dependency "MaterialComponents/Typography"
ss.dependency "MDFTextAccessibility"
ss.subspec "Component" do |sss|
sss.ios.deployment_target = '8.0'
sss.public_header_files = "components/#{ss.base_name}/src/*.h"
sss.source_files = "components/#{ss.base_name}/src/*.{h,m}", "components/#{ss.base_name}/src/private/*.{h,m}"
sss.resources = ["components/#{ss.base_name}/src/Material#{ss.base_name}.bundle"]
sss.dependency "MaterialComponents/Typography"
sss.dependency "MDFTextAccessibility"
end
ss.subspec "ColorThemer" do |sss|
sss.ios.deployment_target = '8.0'
sss.public_header_files = "components/#{ss.base_name}/src/#{sss.base_name}/*.h"
sss.source_files = "components/#{ss.base_name}/src/#{sss.base_name}/*.{h,m}", "components/#{ss.base_name}/src/#{sss.base_name}/private/*.{h,m}"
sss.dependency "MaterialComponents/Themes"
end
end

s.subspec "FlexibleHeader" do |ss|
Expand Down Expand Up @@ -273,9 +289,6 @@ Pod::Spec.new do |s|
ss.ios.deployment_target = '8.0'
ss.public_header_files = "components/#{ss.base_name}/src/*.h"
ss.source_files = "components/#{ss.base_name}/src/*.{h,m}", "components/#{ss.base_name}/src/private/*.{h,m}"

ss.dependency "MaterialComponents/FeatureHighlight"
ss.dependency "MaterialComponents/Dialogs"
end

s.subspec "Typography" do |ss|
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#import "MaterialDialogs.h"
#import "MaterialThemes.h"
#import "MaterialPalettes.h"
#import "MDCAlertColorThemer.h"

@implementation AlertColorThemerTypicalUseViewController

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ - (UICollectionViewCell *)collectionView:(UICollectionView *)collectionView
@implementation AlertColorThemerTypicalUseViewController (CatalogByConvention)

+ (NSArray *)catalogBreadcrumbs {
return @[ @"Themes", @"Theme Alert Dialog" ];
return @[ @"Dialogs", @"Theme Alert Dialog" ];
}

+ (NSString *)catalogDescription {
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#import "MaterialFeatureHighlight.h"
#import "MaterialThemes.h"
#import "MaterialPalettes.h"
#import "MDCFeatureHighlightColorThemer.h"

static NSString *const kTitleText = @"Themed Feature Highlight";
static NSString *const kBodyText =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ - (void)viewDidLayoutSubviews {
}

+ (NSArray *)catalogBreadcrumbs {
return @[ @"Themes", @"Theme Feature Highlight" ];
return @[ @"Feature Highlight", @"Theme Feature Highlight" ];
}

+ (NSString *)catalogDescription {
Expand Down
3 changes: 0 additions & 3 deletions components/Themes/src/MaterialThemes.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,3 @@
*/

#import "MDCColorScheme.h"

#import "MDCAlertColorThemer.h"
#import "MDCFeatureHighlightColorThemer.h"

0 comments on commit 1c7ca93

Please sign in to comment.