Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BottomNavigation] Support titlePositionAdjustment #6721

Merged
merged 2 commits into from Feb 28, 2019
Merged

[BottomNavigation] Support titlePositionAdjustment #6721

merged 2 commits into from Feb 28, 2019

Conversation

romoore
Copy link
Contributor

@romoore romoore commented Feb 27, 2019

UITabBarItem's titlePositionAdjustment property allows individual
items to have the title position adjusted slightly. This change attempts to match the
behavior of UITabBar as closely as possible:

  • RTL does not flip the UIOffset values automatically. Clients need to make that change.
  • Horizontal offsets do not apply when the title and icon are arranged "vertically".

Closes #4446

[BottomNavigation] Support titlePositionAdjustment
00f82ac 
UITabBarItem's `titlePositionAdjustment` property allows individual
items to have the title position adjusted slightly. Although the
behavior within UITabBar is somewhat complex (limited in some layouts,
never beyond view bounds, etc.), for Bottom Navigation it seems
reasonable to allow clients to fully manipulate the label position as
desired.

In the future, the behavior of UITabBar can be more fully determined and
imitated if necessary.

Closes #4446
@romoore romoore added type:Feature request New functionality is desired. [BottomNavigation] labels Feb 27, 2019
@material-automation
Copy link

material-automation commented Feb 27, 2019 •
edited

bazel detected changes to the following targets:

//components/BottomNavigation:snapshot_tests
//components/BottomNavigation:snapshot_tests_test_bundle
//components/BottomNavigation:unit_tests
//components/BottomNavigation:unit_tests_IPAD_PRO_12_9_IN_9_3
//components/BottomNavigation:unit_tests_IPAD_PRO_12_9_IN_9_3_test_bundle
//components/BottomNavigation:unit_tests_IPHONE_5_IN_8_1
//components/BottomNavigation:unit_tests_IPHONE_5_IN_8_1_test_bundle
//components/BottomNavigation:unit_tests_IPHONE_7_PLUS_IN_10_3
//components/BottomNavigation:unit_tests_IPHONE_7_PLUS_IN_10_3_test_bundle
//components/BottomNavigation:unit_tests_IPHONE_X_IN_11_0
//components/BottomNavigation:unit_tests_IPHONE_X_IN_11_0_test_bundle
//components/BottomNavigation:unit_tests_beta
//components/BottomNavigation:unit_tests_beta_test_bundle

@romoore romoore marked this pull request as ready for review February 27, 2019 13:20
@romoore romoore requested a review from a team as a code owner February 27, 2019 13:20
@romoore romoore merged commit 60c60b3 into material-components:develop Feb 28, 2019
@romoore romoore deleted the issue-4446 branch February 28, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@material-automation material-automation material-automation left review comments

@jverkoey jverkoey jverkoey approved these changes

@randallli randallli Awaiting requested review from randallli

Assignees
No one assigned
Labels
[BottomNavigation] cla: yes type:Feature request New functionality is desired.
Projects
None yet
Milestone
No milestone
4 participants
@romoore @material-automation @jverkoey @googlebot