Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BottomNavigation] Support titlePositionAdjustment #6721

Merged
merged 2 commits into from
Feb 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions components/BottomNavigation/src/MDCBottomNavigationBar.m
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
static NSString *const kMDCBottomNavigationBarAccessibilityLabel = @"accessibilityLabel";
static NSString *const kMDCBottomNavigationBarAccessibilityHint = @"accessibilityHint";
static NSString *const kMDCBottomNavigationBarIsAccessibilityElement = @"isAccessibilityElement";
romoore marked this conversation as resolved.
Show resolved Hide resolved
static NSString *const kTitlePositionAdjustment = @"titlePositionAdjustment";

static NSString *const kMDCBottomNavigationBarOfAnnouncement = @"of";

Expand Down Expand Up @@ -322,6 +323,10 @@ - (void)addObserversToTabBarItems {
forKeyPath:kMDCBottomNavigationBarIsAccessibilityElement
options:NSKeyValueObservingOptionNew
context:nil];
[item addObserver:self
forKeyPath:kTitlePositionAdjustment
options:NSKeyValueObservingOptionNew
context:nil];
}
}

Expand All @@ -338,6 +343,7 @@ - (void)removeObserversFromTabBarItems {
[item removeObserver:self forKeyPath:kMDCBottomNavigationBarAccessibilityLabel];
[item removeObserver:self forKeyPath:kMDCBottomNavigationBarAccessibilityHint];
[item removeObserver:self forKeyPath:kMDCBottomNavigationBarIsAccessibilityElement];
[item removeObserver:self forKeyPath:kTitlePositionAdjustment];
} @catch (NSException *exception) {
if (exception) {
// No need to do anything if there are no observers.
Expand Down Expand Up @@ -380,6 +386,8 @@ - (void)observeValueForKeyPath:(NSString *)keyPath
itemView.accessibilityHint = change[kMDCBottomNavigationBarNewString];
} else if ([keyPath isEqualToString:kMDCBottomNavigationBarIsAccessibilityElement]) {
itemView.isAccessibilityElement = [change[kMDCBottomNavigationBarNewString] boolValue];
} else if ([keyPath isEqualToString:kTitlePositionAdjustment]) {
itemView.titlePositionAdjustment = [change[kMDCBottomNavigationBarNewString] UIOffsetValue];
}
}
}
Expand Down Expand Up @@ -482,6 +490,7 @@ - (void)setItems:(NSArray<UITabBarItem *> *)items {
itemView.contentVerticalMargin = self.itemsContentVerticalMargin;
itemView.contentHorizontalMargin = self.itemsContentHorizontalMargin;
itemView.truncatesTitle = self.truncatesLongTitles;
itemView.titlePositionAdjustment = item.titlePositionAdjustment;
MDCInkTouchController *controller = [[MDCInkTouchController alloc] initWithView:itemView];
controller.delegate = self;
[self.inkControllers addObject:controller];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
@property(nonatomic, assign) BOOL selected;
@property(nonatomic, assign) MDCBottomNavigationBarTitleVisibility titleVisibility;
@property(nonatomic, strong) MDCInkView *inkView;
@property(nonatomic, assign) UIOffset titlePositionAdjustment;

@property(nonatomic, copy) NSString *badgeValue;
@property(nonatomic, copy) NSString *title;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,9 @@ - (void)calculateVerticalLayoutInBounds:(CGRect)contentBounds
CGFloat centerX = CGRectGetMidX(contentBoundingRect);
CGPoint iconImageViewCenter =
CGPointMake(centerX, centerY - totalContentHeight / 2 + iconHeight / 2);
CGPoint labelCenter = CGPointMake(centerX, centerY + totalContentHeight / 2 - labelHeight / 2);
// Ignore the horizontal titlePositionAdjustment in a vertical layout to match UITabBar behavior.
CGPoint labelCenter = CGPointMake(centerX, centerY + totalContentHeight / 2 - labelHeight / 2 +
self.titlePositionAdjustment.vertical);
CGFloat availableContentWidth = CGRectGetWidth(contentBoundingRect);
if (self.truncatesTitle && (labelSize.width > availableContentWidth)) {
labelSize = CGSizeMake(availableContentWidth, labelSize.height);
Expand Down Expand Up @@ -301,8 +303,9 @@ - (void)calculateHorizontalLayoutInBounds:(CGRect)contentBounds
CGPointMake(layoutStartingPoint + rtlCoefficient * iconCenterOffset, centerY);
CGFloat labelOffsetFromIcon =
iconImageViewSize.width / 2 + self.contentHorizontalMargin + labelSize.width / 2;
CGPoint labelCenter =
CGPointMake(iconImageViewCenter.x + rtlCoefficient * labelOffsetFromIcon, centerY);
CGPoint labelCenter = CGPointMake(iconImageViewCenter.x + rtlCoefficient * labelOffsetFromIcon +
self.titlePositionAdjustment.horizontal,
centerY + self.titlePositionAdjustment.vertical);

// Assign the frames to the inout arguments
if (outLabelFrame != NULL) {
Expand Down Expand Up @@ -558,6 +561,13 @@ - (NSString *)accessibilityIdentifier {
return self.button.accessibilityIdentifier;
}

- (void)setTitlePositionAdjustment:(UIOffset)titlePositionAdjustment {
if (!UIOffsetEqualToOffset(_titlePositionAdjustment, titlePositionAdjustment)) {
_titlePositionAdjustment = titlePositionAdjustment;
[self setNeedsLayout];
}
}

#pragma mark - Resource bundle

+ (NSBundle *)bundle {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -830,6 +830,90 @@ - (void)testCenteredRegularAlwaysFiveItemsFitWidthFitHeightRTL {
[self generateAndVerifySnapshot];
}

#pragma mark - Layout Adjustments

- (void)testTitlePositionAdjustmentJustifiedAdjacentCompactLTR {
// Given
MDCMutableUITraitCollection *traitCollection = [[MDCMutableUITraitCollection alloc] init];
traitCollection.horizontalSizeClassOverride = UIUserInterfaceSizeClassCompact;
self.navigationBar.titleVisibility = MDCBottomNavigationBarTitleVisibilityAlways;
self.navigationBar.alignment = MDCBottomNavigationBarAlignmentJustifiedAdjacentTitles;
self.navigationBar.selectedItem = self.tabItem2;
self.navigationBar.traitCollectionOverride = traitCollection;
CGSize fitSize = [self.navigationBar sizeThatFits:CGSizeMake(kWidthWide, kHeightTall)];
self.navigationBar.frame = CGRectMake(0, 0, fitSize.width, fitSize.height);
[self performInkTouchOnBar:self.navigationBar item:self.tabItem1];

// When
self.tabItem1.titlePositionAdjustment = UIOffsetMake(20, -20);
self.tabItem3.titlePositionAdjustment = UIOffsetMake(-20, 20);

// Then
[self generateAndVerifySnapshot];
}

- (void)testTitlePositionAdjustmentJustifiedAdjacentCompactRTL {
// Given
MDCMutableUITraitCollection *traitCollection = [[MDCMutableUITraitCollection alloc] init];
traitCollection.horizontalSizeClassOverride = UIUserInterfaceSizeClassCompact;
self.navigationBar.titleVisibility = MDCBottomNavigationBarTitleVisibilityAlways;
self.navigationBar.alignment = MDCBottomNavigationBarAlignmentJustifiedAdjacentTitles;
self.navigationBar.selectedItem = self.tabItem2;
self.navigationBar.traitCollectionOverride = traitCollection;
CGSize fitSize = [self.navigationBar sizeThatFits:CGSizeMake(kWidthWide, kHeightTall)];
self.navigationBar.frame = CGRectMake(0, 0, fitSize.width, fitSize.height);
[self performInkTouchOnBar:self.navigationBar item:self.tabItem1];
[self changeToRTLAndArabicWithTitle:kShortTitleArabic];

// When
self.tabItem1.titlePositionAdjustment = UIOffsetMake(20, -20);
self.tabItem3.titlePositionAdjustment = UIOffsetMake(-20, 20);

// Then
[self generateAndVerifySnapshot];
}

- (void)testTitlePositionAdjustmentJustifiedAdjacentRegularLTR {
// Given
MDCMutableUITraitCollection *traitCollection = [[MDCMutableUITraitCollection alloc] init];
traitCollection.horizontalSizeClassOverride = UIUserInterfaceSizeClassRegular;
self.navigationBar.titleVisibility = MDCBottomNavigationBarTitleVisibilityAlways;
self.navigationBar.alignment = MDCBottomNavigationBarAlignmentJustifiedAdjacentTitles;
self.navigationBar.selectedItem = self.tabItem2;
self.navigationBar.traitCollectionOverride = traitCollection;
CGSize fitSize = [self.navigationBar sizeThatFits:CGSizeMake(kWidthWide, kHeightTall)];
self.navigationBar.frame = CGRectMake(0, 0, fitSize.width, fitSize.height);
[self performInkTouchOnBar:self.navigationBar item:self.tabItem1];

// When
self.tabItem1.titlePositionAdjustment = UIOffsetMake(20, -20);
self.tabItem3.titlePositionAdjustment = UIOffsetMake(-20, 20);

// Then
[self generateAndVerifySnapshot];
}

- (void)testTitlePositionAdjustmentJustifiedAdjacentRegularRTL {
// Given
MDCMutableUITraitCollection *traitCollection = [[MDCMutableUITraitCollection alloc] init];
traitCollection.horizontalSizeClassOverride = UIUserInterfaceSizeClassRegular;
self.navigationBar.titleVisibility = MDCBottomNavigationBarTitleVisibilityAlways;
self.navigationBar.alignment = MDCBottomNavigationBarAlignmentJustifiedAdjacentTitles;
self.navigationBar.selectedItem = self.tabItem2;
self.navigationBar.traitCollectionOverride = traitCollection;
CGSize fitSize = [self.navigationBar sizeThatFits:CGSizeMake(kWidthWide, kHeightTall)];
self.navigationBar.frame = CGRectMake(0, 0, fitSize.width, fitSize.height);
[self performInkTouchOnBar:self.navigationBar item:self.tabItem1];
[self changeToRTLAndArabicWithTitle:kShortTitleArabic];

// When
self.tabItem1.titlePositionAdjustment = UIOffsetMake(20, -20);
self.tabItem3.titlePositionAdjustment = UIOffsetMake(-20, 20);

// Then
[self generateAndVerifySnapshot];
}

#pragma mark - Theming Material baseline

- (void)testMaterialBaselineTheme {
Expand Down
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.