feat(top app bar): dense variant #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgr34
changed the title
mgr34
changed the title
moog16
suggested changes
Dec 14, 2018
| @@ -63,6 +63,11 @@ test('has correct fixed class', () => { | |||
| assert.isTrue(wrapper.hasClass('mdc-top-app-bar--fixed')); | |||
| }); | |||
|
|
|||
| test('has correct dense class', () => { | |||
There was a problem hiding this comment.
can you also add one for dense prominent variant?
Codecov Report
@@ Coverage Diff @@
## rc0.8.0 #520 +/- ##
========================================
Coverage 96.62% 96.62%
========================================
Files 59 59
Lines 1984 1984
Branches 235 235
========================================
Hits 1917 1917
Misses 67 67
Continue to review full report at Codecov.
|
|
Please add this commit to your PR dc69fe1 |
|
Also you need to "sign" in a separate commit. The CLA hasn't passed. |
|
I signed it
@moog16 like this? this instruction is a little unclear to me. thanks for the review. |
|
tests passing #523 |
|
Woo! Thanks |
moog16
pushed a commit
that referenced
this pull request
Dec 28, 2018
moog16
pushed a commit
that referenced
this pull request
Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds missing dense variant. See issue #518. As noted on discord I am having trouble getting screenshot testing to run. But I did add two. A
TopAppBarDenseand aTopAppBarProminetDense. Both will be modified further in an additional PR that adds the correct class to<TopAppBarFixedAdjust>I signed it.