-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linear-progress): typescript #526
Conversation
This reverts commit d486cef.
packages/linear-progress/index.tsx
Outdated
isMounted_ = false; | ||
bufferElement_: React.RefObject<HTMLDivElement> = React.createRef(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing underscore.
<Tag className={this.classes} role="progressbar" {...otherProps}> | ||
{bufferingDots && <div className="mdc-linear-progress__buffering-dots"></div>} | ||
<div className="mdc-linear-progress__buffer" ref={this.bufferElement_}></div> | ||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on why this ignore is needed.
Also, why do we need to destructure all of the props here if most of them are unused ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they need to be defined so that they don't appear in ...otherProps. It is like black listing
packages/linear-progress/index.tsx
Outdated
isMounted_ = false; | ||
bufferElement: React.RefObject<HTMLDivElement> = React.createRef(); | ||
primaryBarElement_: React.RefObject<HTMLDivElement> = React.createRef(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove trailing underscore.
packages/linear-progress/index.tsx
Outdated
isMounted_ = false; | ||
bufferElement: React.RefObject<HTMLDivElement> = React.createRef(); | ||
primaryBarElement_: React.RefObject<HTMLDivElement> = React.createRef(); | ||
foundation_: MDCLinearProgressFoundation; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove trailing underscore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually can use the private keyword!
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
related #48