feat(linear-progress): typescript #526
Conversation
This reverts commit d486cef.
packages/linear-progress/index.tsx
Outdated
| isMounted_ = false; | ||
| bufferElement_: React.RefObject<HTMLDivElement> = React.createRef(); |
There was a problem hiding this comment.
Remove trailing underscore.
| <Tag className={this.classes} role="progressbar" {...otherProps}> | ||
| {bufferingDots && <div className="mdc-linear-progress__buffering-dots"></div>} | ||
| <div className="mdc-linear-progress__buffer" ref={this.bufferElement_}></div> | ||
| // @ts-ignore |
There was a problem hiding this comment.
Comment on why this ignore is needed.
Also, why do we need to destructure all of the props here if most of them are unused ?
There was a problem hiding this comment.
they need to be defined so that they don't appear in ...otherProps. It is like black listing
packages/linear-progress/index.tsx
Outdated
| isMounted_ = false; | ||
| bufferElement: React.RefObject<HTMLDivElement> = React.createRef(); | ||
| primaryBarElement_: React.RefObject<HTMLDivElement> = React.createRef(); |
There was a problem hiding this comment.
remove trailing underscore.
packages/linear-progress/index.tsx
Outdated
| isMounted_ = false; | ||
| bufferElement: React.RefObject<HTMLDivElement> = React.createRef(); | ||
| primaryBarElement_: React.RefObject<HTMLDivElement> = React.createRef(); | ||
| foundation_: MDCLinearProgressFoundation; |
There was a problem hiding this comment.
remove trailing underscore.
There was a problem hiding this comment.
actually can use the private keyword!
|
|
moog16
changed the base branch from
fix/coverage-typescript
to
feat/two-typescript
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
related #48