feat(card): typescript #497
Conversation
This reverts commit d486cef.
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
| import * as React from 'react'; |
| @@ -19,46 +19,38 @@ | |||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | |||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
| // THE SOFTWARE. | |||
| import * as React from 'react'; | |||
| @@ -19,42 +19,25 @@ | |||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | |||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
| // THE SOFTWARE. | |||
| import * as React from 'react'; | |||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
| import * as React from 'react'; |
| import classnames from 'classnames'; | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| import * as React from 'react'; |
packages/card/PrimaryContent.tsx
Outdated
|
|
||
| import * as React from 'react'; | ||
| import * as classnames from 'classnames'; | ||
| // @ts-ignore |
There was a problem hiding this comment.
Add comment for why this is needed.
| import React from 'react'; | ||
| import classnames from 'classnames'; | ||
| import PropTypes from 'prop-types'; | ||
| import * as React from 'react'; |
moog16
changed the base branch from
fix/coverage-typescript
to
feat/two-typescript
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
related #48