Skip to content

Commit

Permalink
fix(infrastructure): Unexpose private tab (#2499)
Browse files Browse the repository at this point in the history
Unexpose the private Tab component. Add a brief check inside of the check-deps script that ignores private packages.

Fixes #2498
  • Loading branch information
patrickrodee authored Apr 3, 2018
1 parent ea72f03 commit 306fd7f
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 215 deletions.
148 changes: 0 additions & 148 deletions demos/tab.html

This file was deleted.

60 changes: 0 additions & 60 deletions demos/tab.scss

This file was deleted.

3 changes: 0 additions & 3 deletions packages/material-components-web/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ import * as select from '@material/select/index';
import * as selectionControl from '@material/selection-control/index';
import * as slider from '@material/slider/index';
import * as snackbar from '@material/snackbar/index';
import * as tab from '@material/tab/index';
import * as tabs from '@material/tabs/index';
import * as textField from '@material/textfield/index';
import * as toolbar from '@material/toolbar/index';
Expand All @@ -57,7 +56,6 @@ autoInit.register('MDCLinearProgress', linearProgress.MDCLinearProgress);
autoInit.register('MDCNotchedOutline', notchedOutline.MDCNotchedOutline);
autoInit.register('MDCRadio', radio.MDCRadio);
autoInit.register('MDCSnackbar', snackbar.MDCSnackbar);
autoInit.register('MDCTab_', tab.MDCTab);
autoInit.register('MDCTab', tabs.MDCTab);
autoInit.register('MDCTabBar', tabs.MDCTabBar);
autoInit.register('MDCTextField', textField.MDCTextField);
Expand Down Expand Up @@ -89,7 +87,6 @@ export {
selectionControl,
slider,
snackbar,
tab,
tabs,
textField,
toolbar,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
@import "@material/slider/mdc-slider";
@import "@material/snackbar/mdc-snackbar";
@import "@material/switch/mdc-switch";
@import "@material/tab/mdc-tab";
@import "@material/tabs/mdc-tabs";
@import "@material/textfield/mdc-text-field";
@import "@material/theme/mdc-theme";
Expand Down
1 change: 0 additions & 1 deletion packages/material-components-web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
"@material/slider": "^0.34.0",
"@material/snackbar": "^0.34.0",
"@material/switch": "^0.34.0",
"@material/tab": "^0.34.0",
"@material/tabs": "^0.34.0",
"@material/textfield": "^0.34.0",
"@material/theme": "^0.34.0",
Expand Down
4 changes: 4 additions & 0 deletions scripts/check-pkg-for-release.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ function checkCSSDependencyAddedInWebpackConfig() {
}

function checkDependencyAddedInMDCPackage() {
if (pkg.private) {
console.log('Skipping private component', pkg.name);
return;
}
// Package is added to package.json
checkPkgDependencyAddedInMDCPackage();

Expand Down
1 change: 0 additions & 1 deletion scripts/webpack/css-bundle-factory.js
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ class CssBundleFactory {
'mdc.slider': getAbsolutePath('/packages/mdc-slider/mdc-slider.scss'),
'mdc.snackbar': getAbsolutePath('/packages/mdc-snackbar/mdc-snackbar.scss'),
'mdc.switch': getAbsolutePath('/packages/mdc-switch/mdc-switch.scss'),
'mdc.tab': getAbsolutePath('/packages/mdc-tab/mdc-tab.scss'),
'mdc.tabs': getAbsolutePath('/packages/mdc-tabs/mdc-tabs.scss'),
'mdc.textfield': getAbsolutePath('/packages/mdc-textfield/mdc-text-field.scss'),
'mdc.theme': getAbsolutePath('/packages/mdc-theme/mdc-theme.scss'),
Expand Down
1 change: 0 additions & 1 deletion scripts/webpack/js-bundle-factory.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ class JsBundleFactory {
selectionControl: getAbsolutePath('/packages/mdc-selection-control/index.js'),
slider: getAbsolutePath('/packages/mdc-slider/index.js'),
snackbar: getAbsolutePath('/packages/mdc-snackbar/index.js'),
tab: getAbsolutePath('/packages/mdc-tab/index.js'),
tabs: getAbsolutePath('/packages/mdc-tabs/index.js'),
textfield: getAbsolutePath('/packages/mdc-textfield/index.js'),
toolbar: getAbsolutePath('/packages/mdc-toolbar/index.js'),
Expand Down

0 comments on commit 306fd7f

Please sign in to comment.