Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and standardize settings context var #237

Closed
shyamd opened this issue Jul 22, 2021 · 1 comment
Closed

Fix and standardize settings context var #237

shyamd opened this issue Jul 22, 2021 · 1 comment

Comments

@shyamd
Copy link
Contributor

shyamd commented Jul 22, 2021

emmet.builder.SETTINGS and emmet.core.SETTINGS should be context vars that can be "localy" overridden by builders. This makes it easier to change settings on a builder-by-builder basis and know that you're affecting all appropriate utility functions, etc.
@shyamd
Copy link
Contributor Author

shyamd commented Jul 23, 2021

Nixing this idea as its complicated implementation is likely to confuse people.

@shyamd shyamd closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shyamd