Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LU translation functions don't serialize #11

Closed
shyamd opened this issue Dec 15, 2017 · 2 comments
Closed

LU translation functions don't serialize #11

shyamd opened this issue Dec 15, 2017 · 2 comments

Comments

@shyamd
Copy link
Contributor

shyamd commented Dec 15, 2017

The LU translator functions don't json serialize so the Store no longer dumps to json if you use one of them. I'll leave it up to you to decide how you want to deal with this. I'd think we might just have key type strings and the stores just translate to a standard internal format?

@dwinston
Copy link
Member

I'm fine with e.g. assert lu_key in ['datetime', 'isoformat'] and mapping those str keys to the current function-pairs. I'm not interested in supporting other lu_field formats. I don't think any other formats are in use by anyone.

@shyamd
Copy link
Contributor Author

shyamd commented Dec 20, 2017

fixed in 58b3e4e

@shyamd shyamd closed this as completed Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants