Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MongoURIStore #93

Merged
merged 8 commits into from
Jan 28, 2020
Merged

Add MongoURIStore #93

merged 8 commits into from
Jan 28, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jan 28, 2020

Adds a MongoURI Store for special mongodb+srv:// URIs that fully setup the mongo client from DNS records

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #93 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #93      +/-   ##
=========================================
+ Coverage   86.97%   87.1%   +0.13%     
=========================================
  Files          20      20              
  Lines        1443    1458      +15     
=========================================
+ Hits         1255    1270      +15     
  Misses        188     188
Impacted Files Coverage Δ
src/maggma/stores/mongolike.py 94.21% <100%> (+0.49%) ⬆️
src/maggma/stores/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3a1a31...5e27ddd. Read the comment docs.

@shyamd shyamd merged commit 7a85beb into master Jan 28, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2020

This pull request introduces 1 alert when merging 5e27ddd into 98642b8 - view on LGTM.com

new alerts:

  • 1 for First argument to super() is not enclosing class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant