Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations to io/lammps #3379

Merged
merged 9 commits into from
Oct 6, 2023
Merged

Add type annotations to io/lammps #3379

merged 9 commits into from
Oct 6, 2023

Conversation

ab5424
Copy link
Contributor

@ab5424 ab5424 commented Oct 6, 2023 •
edited
Loading

Summary

Major changes:

  • Added (some) type annotations to io/lammps and fixed some typos.

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.

janosh
janosh approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you very much!

@janosh janosh merged commit cf0be37 into materialsproject:master Oct 6, 2023
22 checks passed
@ab5424 ab5424 deleted the type-annotations branch October 6, 2023 14:46
@janosh janosh added the types Type all the things label Oct 10, 2023
@ab5424 ab5424 mentioned this pull request Oct 11, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

Assignees
No one assigned
Labels
types Type all the things
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ab5424 @janosh