Skip to content

Add type annotations to io/lammps - #3379

Merged
janosh merged 9 commits into
materialsproject:masterfrom
ab5424:type-annotations
Oct 6, 2023
Merged

janosh merged 9 commits into
materialsproject:masterfrom
ab5424:type-annotations

Conversation

@ab5424

@ab5424 ab5424 commented Oct 6, 2023 •

Copy link
Copy Markdown
Contributor

Summary

Major changes:

  • Added (some) type annotations to io/lammps and fixed some typos.

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.

@janosh janosh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you very much!

@janosh
janosh merged commit cf0be37 into materialsproject:master Oct 6, 2023
@ab5424
ab5424 deleted the type-annotations branch October 6, 2023 14:46
@janosh janosh added the types Type all the things label Oct 10, 2023
@ab5424 ab5424 mentioned this pull request Oct 11, 2023
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

types Type all the things

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants