Skip to content

Fix type annotations in phonon/ and lammps/ #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix type annotations in phonon/ and lammps/ #3401

merged 1 commit into from
Oct 11, 2023

Conversation

@ab5424
Copy link
Contributor

@ab5424 ab5424 commented Oct 11, 2023 •
edited
Loading

Summary

Major changes:

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.

@ab5424 ab5424 mentioned this pull request Oct 11, 2023
Merged
2 tasks
@janosh janosh enabled auto-merge (squash) October 11, 2023 19:37
@janosh janosh added compatability Concerning pymatgen compatibility with different OS, Python versions, numpy versions, etc. fix Bug fix PRs labels Oct 11, 2023
@janosh janosh merged commit b9a4ef4 into materialsproject:master Oct 11, 2023
@ab5424 ab5424 deleted the gruneisen-annotations branch October 13, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

compatability Concerning pymatgen compatibility with different OS, Python versions, numpy versions, etc. fix Bug fix PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ab5424 @janosh