Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Screen jitter on edit screen when reading date section is displayed #501

Closed
pandalamp opened this issue Feb 20, 2024 · 3 comments · Fixed by #504
Closed

[BUG] Screen jitter on edit screen when reading date section is displayed #501

pandalamp opened this issue Feb 20, 2024 · 3 comments · Fixed by #504
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pandalamp
Copy link

Describe the bug
A screen jitter occurs on input when using the edit page if the reading date boxes are displayed.

To Reproduce
Press the Capture Reading button on the edit page to show the date boxes and then add text to any field below the date section, or above it while the boxes are visible on screen.

Screenshots
https://github.com/mateusz-bak/openreads/assets/65859489/02cce429-1d32-4f42-93d4-b88a2f183694

Additional info(please complete the following information):

  • App version: 2.5.0
  • App source F-Droid, Google Play
  • Manufacturer and model: Google Pixel 7
  • OS and version: Android 14

Additional context
I thought this might be related to input method and tested with different keyboards with no change.

@pandalamp pandalamp added the bug Something isn't working label Feb 20, 2024
@mateusz-bak mateusz-bak added this to the Release 2.5.1 milestone Feb 21, 2024
@mateusz-bak
Copy link
Owner

Thanks, will take a look

@mateusz-bak
Copy link
Owner

Each change in the edit forms would cause the readings to rebuild due to re-initializing date's format each time.

I moved the date format initialization to main file so it is done only once and is not re-initialized again.

Will be released in 2.5.1

@pandalamp
Copy link
Author

Each change in the edit forms would cause the readings to rebuild due to re-initializing date's format each time.

I moved the date format initialization to main file so it is done only once and is not re-initialized again.

Will be released in 2.5.1

Awesome! Thank you for the explanation and the fix! 🐼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants