Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semi_additive is also defined in MathComp 2 #1072

Open
affeldt-aist opened this issue Oct 30, 2023 · 3 comments
Open

semi_additive is also defined in MathComp 2 #1072

affeldt-aist opened this issue Oct 30, 2023 · 3 comments
Labels
renaming/refactoring 🔧 This is about a renaming or refactoring in the library
Milestone

Comments

@affeldt-aist
Copy link
Member

Definition semi_additive := forall F n,

this will conflict with Nmodule @proux01

@proux01
Copy link
Collaborator

proux01 commented Oct 30, 2023

They remain accessible as GRing.semi_additive and measure.semi_additive so it doesn't look that catastrophic.

@affeldt-aist
Copy link
Member Author

affeldt-aist commented Oct 30, 2023

I didn't mean to sound catastrophic ^_^, I just thought that it might be a good timing to think of a name change, I don't think that the semi_ prefix here is as important as it is for NModule @CohenCyril (no hurry anyway)

@affeldt-aist affeldt-aist added this to the 1.5.0 milestone Aug 13, 2024
@affeldt-aist affeldt-aist added the renaming/refactoring 🔧 This is about a renaming or refactoring in the library label Aug 13, 2024
@affeldt-aist
Copy link
Member Author

NB: not addressed yet but considered low priority, discussed during the following meeting https://github.com/math-comp/analysis/wiki/2026-06-26-Meeting

@affeldt-aist affeldt-aist modified the milestones: 1.5.0, 1.6.0 Oct 7, 2024
@affeldt-aist affeldt-aist modified the milestones: 1.6.0, 1.7.0 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renaming/refactoring 🔧 This is about a renaming or refactoring in the library
Projects
None yet
Development

No branches or pull requests

2 participants