Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

want to use just fct_ringType from topology.v #456

Closed
t6s opened this issue Oct 19, 2021 · 3 comments
Closed

want to use just fct_ringType from topology.v #456

t6s opened this issue Oct 19, 2021 · 3 comments
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Milestone

Comments

@t6s
Copy link
Member

t6s commented Oct 19, 2021

There is a ringType decaration for function types in topology.v,
which I have recently found useful for some projects (namely affeldt-aist/infotheo and ieva-itu/robustmean) with no topology.

Unfortunately, importing topology conflicts with Morphism from Coq standard library which reserves the notation --> differently. I have to do some dirty coding to avoid this problem.

Could this be solved perhaps by separating the ring declaration out of topology.v?
(Or perhaps by changing the reserved notation -->?)

@affeldt-aist affeldt-aist added this to the 0.3.12 milestone Nov 8, 2021
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Nov 8, 2021
@affeldt-aist affeldt-aist modified the milestones: 0.3.12, 0.3.13 Dec 28, 2021
@affeldt-aist affeldt-aist modified the milestones: 0.3.13, 0.3.14 Jan 23, 2022
@affeldt-aist
Copy link
Member

It has been pointed out during the last mca meeting that a new feature of Coq (https://coq.inria.fr/refman/language/core/modules.html#grammar-token-import_categories) could help you solve this issue (by preventing loading of the conflicting notation). If it works for you, we can maybe avoid splitting topology.v for now and close this issue. What do you think? (No hurry.)

@affeldt-aist affeldt-aist modified the milestones: 0.4, 0.4.1 Feb 25, 2022
@affeldt-aist affeldt-aist modified the milestones: 0.4.1, 0.4.2 Mar 22, 2022
@affeldt-aist affeldt-aist modified the milestones: 0.5.1, 0.5.2 May 13, 2022
@CohenCyril CohenCyril modified the milestones: 0.5.2, 0.5.3 Jul 8, 2022
@affeldt-aist affeldt-aist modified the milestones: 0.5.3, 0.5.4 Aug 2, 2022
@affeldt-aist affeldt-aist modified the milestones: 0.5.4, 0.6 Sep 2, 2022
@affeldt-aist affeldt-aist modified the milestones: 0.6, 0.6.1 Oct 27, 2022
@affeldt-aist affeldt-aist modified the milestones: 0.6.1, 0.6.2 Feb 9, 2023
@affeldt-aist affeldt-aist modified the milestones: 0.6.2, 0.6.3 Apr 19, 2023
@proux01
Copy link
Collaborator

proux01 commented Apr 19, 2023

@affeldt-aist this issue seem to be fixed now as fct_ringType is now in the classical package (in functions.v). @t6s do you confirm?

@t6s
Copy link
Member Author

t6s commented Apr 19, 2023

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

No branches or pull requests

4 participants