Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three new front-end coding standards #33

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Add three new front-end coding standards #33

merged 2 commits into from
Feb 4, 2022

Conversation

seancolsen
Copy link
Contributor

No description provided.

@seancolsen
Copy link
Contributor Author

seancolsen commented Feb 4, 2022

@pavish Can you review this?

See ba4c1a1 for the standards I've added (after doing some preliminary cleanup).

I'm proposing three new standards

Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seancolsen I am in agreement with all the points mentioned.

Regarding avoiding margin on components, I think it should be strictly enforced only on common components.

For narrow components used only for specific purposes, such as the one in the code that is referenced, it would be good to avoid margins on the root element, but I think it should be a guideline to follow, instead of a strict imposition.

@pavish pavish merged commit a6a0b92 into master Feb 4, 2022
@pavish pavish deleted the fe-standards branch February 4, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants