Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type configuration for Text, Number, Boolean, and all mathesar types with single associated db type #926

Merged
merged 43 commits into from
Feb 4, 2022

Conversation

pavish
Copy link
Member

@pavish pavish commented Jan 2, 2022

Related to:

The PR handles the database options in the data type selection dropdown, for Text, Number, Boolean and all mathesar types with a single db type association.

Screenshot 2022-02-01 at 3 01 51 PM

The discussion Dynamic Type selection & customization on the frontend #1035 provides the declarative format and additional concerns. I advise the reviewers to review this PR after reading the discussion.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@pavish pavish changed the base branch from master to form-builder January 2, 2022 18:52
@dmos62
Copy link
Contributor

dmos62 commented Jan 4, 2022

Hey @pavish, I found the title of this PR interesting and would like to know more. Could you comment on why types with one-to-one type mappings require distinct configuration? I've not looked at the code.

@pavish
Copy link
Member Author

pavish commented Jan 4, 2022

@dmos62 Types with 1-1 mapping do not require a distinct configuration for showing a form and determining db type. They require it for showing what kind of input to use in the table cell, icons, validation of input, formatting the input etc., CellInput is not handled in this PR and would be a subsequent PR. CellInput would also rely on this configuration.

@pavish pavish marked this pull request as ready for review February 1, 2022 09:52
@pavish pavish requested a review from a team February 1, 2022 09:52
@seancolsen seancolsen self-assigned this Feb 1, 2022
@pavish pavish added the pr-status: review A PR awaiting review label Feb 2, 2022
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After playing with these changes, this PR doesn't appear to break any existing functionality.

I've looked over the diff and don't see any glaring red flags.

So for the sake of moving fast, I'm merging this.

That said, there are some smaller concerns and questions with these changes that I plan to address through a combination of tickets, subsequent PRs, and sync conversations.

@seancolsen seancolsen merged commit db9fa80 into master Feb 4, 2022
@seancolsen seancolsen deleted the type_config branch February 4, 2022 17:12
@pavish
Copy link
Member Author

pavish commented Feb 4, 2022

@seancolsen This PR does not handle saving the user entered input in the forms on the db yet eg., Decimal places, Field Size limitetc.,. I'll be raising a subsequent PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants