Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exploration share link not working #3452

Closed
ghislaineguerin opened this issue Feb 21, 2024 · 3 comments · Fixed by #3456
Closed

Exploration share link not working #3452

ghislaineguerin opened this issue Feb 21, 2024 · 3 comments · Fixed by #3456
Assignees
@pavish
Labels
needs: troubleshooting Issues that we can't reproduce or need to investigate further before picking a course of action regression restricted: maintainers Only maintainers can resolve this issue type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Milestone
v0.1.5

Comments

@ghislaineguerin
Copy link
Contributor

Description

When creating a share link for explorations and then navigating to the page, I'm getting a "No page found" error.

Expected behavior

The shared exploration should load.

To Reproduce

  • Go to an exploration and create a share link
  • Navigate to the link
@ghislaineguerin ghislaineguerin added type: bug Something isn't working needs: triage This issue has not yet been reviewed by a maintainer labels Feb 21, 2024
@pavish pavish added work: frontend Related to frontend code in the mathesar_ui directory regression needs: troubleshooting Issues that we can't reproduce or need to investigate further before picking a course of action and removed needs: triage This issue has not yet been reviewed by a maintainer labels Feb 21, 2024
@seancolsen
Copy link
Contributor

I'm reproducing this.

image

I get the same behavior when viewing the share link as authenticated and anonymous.

@pavish pavish added the restricted: maintainers Only maintainers can resolve this issue label Feb 21, 2024
@pavish pavish added this to the v0.1.5 milestone Feb 21, 2024
@pavish pavish self-assigned this Feb 21, 2024
@seancolsen seancolsen mentioned this issue Feb 25, 2024
Closed
7 tasks
@seancolsen
Copy link
Contributor

@pavish heads up that I took a quick crack at this today just in case you ended up being short on time. At the very least, reviewing this PR will help you see where the problem is — within SharedExplorationRoute.svelte the database variable was undefined. I made some changes to the child components to allow a missing database, which I think is okay, but I'd like you to take a close look since you know more than me about what functionality to expect from the database share page.

@kgodey kgodey assigned seancolsen and unassigned pavish Feb 26, 2024
@pavish
Copy link
Member

pavish commented Feb 26, 2024

See comment for root cause. This seems to be a backend regression. I'm reassigning this issue to me.

@pavish pavish assigned pavish and unassigned seancolsen Feb 26, 2024
@pavish pavish mentioned this issue Feb 26, 2024
Closed
@pavish pavish added work: backend Related to Python, Django, and simple SQL and removed work: frontend Related to frontend code in the mathesar_ui directory labels Feb 26, 2024
@pavish pavish mentioned this issue Feb 26, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavish pavish

Labels
needs: troubleshooting Issues that we can't reproduce or need to investigate further before picking a course of action regression restricted: maintainers Only maintainers can resolve this issue type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Projects
None yet
Milestone
v0.1.5
3 participants
@seancolsen @ghislaineguerin @pavish