Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regressions with exploration and table shares #3454

Closed
wants to merge 4 commits into from

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Feb 25, 2024

Fixes #3452
Fixes #3455

Notes

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen added this to the v0.1.5 milestone Feb 25, 2024
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Feb 25, 2024
@seancolsen
Copy link
Contributor Author

Update: Hmmm, it seems like #3455 maybe is related. It seems like maybe we need to have the currentDatabase store set within these "share" pages in order to have the derived currentDbAbstractTypes store become defined. 🤔 I need to sign off for today, but I'll leave this thought here in case you want to pick up on this digging.

@seancolsen
Copy link
Contributor Author

Ok, I got some more time to dig deeper, and I'm feeling a little more confident in this fix. I pushed some more commits to address #3455 too.

@seancolsen seancolsen changed the title Make database prop optional to fix exploration share 404 Fix regressions with exploration and table shares Feb 26, 2024
@pavish
Copy link
Member

pavish commented Feb 26, 2024

@seancolsen This seems to be a regression on the backend. We are no longer receiving anything within the connections key in the common_data which is essential, instead it's received in the databases key.

I'm going to close the PR since it's not fixing the underlying issue. The idea was for the components to always expect the database prop to be defined.

I'd like the following changes, but we can get that done in a different PR:

  • I think we should be throwing an error on the frontend if there's nothing on the connections list but there's a current_connection set.
  • I'd also want the the type duplication fix you made in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column types not showing within shared tables and explorations Exploration share link not working
2 participants