-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement grouping options for money types #419
Comments
@kgodey can i work on this? |
@Aditramesh This is a really old issue and I'm not sure how valid it is. Please check to see if money data types support all the same grouping types as number data types – if they don't, then you can work on it. |
@kgodey i can try doing that but if there is an issue which has higher priority and if you think I can solve it ,can you assign that to me ? |
@Aditramesh I don't have any issues that I can think of right now. We will probably have more issues in around two weeks. The core team is busy with preparing for our initial release right now, so we haven't had much time to go through our issues recently. |
Understood,then I will try to work on this ,thanks @kgodey |
Unassigned due to inactivity. |
@Anish9901 i couldnt work much on this issue in the last two weeks but i have made some progress and i want to continue working on it,could you reassign this ? |
Please create a PR @Aditramesh and I'll reassign the issue to you. |
Closing this, too old, requirements are out of date. We can create a new issue if we need this functionality in the future. |
Problem
We need to ensure that records that include columns of all Money types support range based grouping just like Number types via the API. Please see #384 for the implementation details.
We should be able to reuse the implementation for Number types here.
This involves:
/api/v0/databases/<id>/types/
endpoint to store available grouping on this typeAdditional context
sqlalchemy-filters
to provide filtering. See: https://github.com/centerofci/sqlalchemy-filters.MONEY
data type in the backend. #420The text was updated successfully, but these errors were encountered: