Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement grouping options for money types #419

Closed
Tracked by #249
kgodey opened this issue Jul 17, 2021 · 9 comments
Closed
Tracked by #249

Implement grouping options for money types #419

kgodey opened this issue Jul 17, 2021 · 9 comments
Labels
ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Milestone

Comments

@kgodey
Copy link
Contributor

kgodey commented Jul 17, 2021

Problem

We need to ensure that records that include columns of all Money types support range based grouping just like Number types via the API. Please see #384 for the implementation details.

We should be able to reuse the implementation for Number types here.

This involves:

  • Implementing the grouping in the backend
  • Updating the /api/v0/databases/<id>/types/ endpoint to store available grouping on this type

Additional context

@kgodey kgodey added needs: unblocking Blocked by other work type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL work: database labels Jul 17, 2021
@kgodey kgodey added this to the 07. Initial Data Types milestone Jul 17, 2021
@kgodey kgodey changed the title Implement grouping options for the Mathesar money type Implement grouping options for money types Jul 18, 2021
@silentninja silentninja added ready Ready for implementation and removed needs: unblocking Blocked by other work labels Feb 14, 2022
@Aditramesh
Copy link

@kgodey can i work on this?

@kgodey
Copy link
Contributor Author

kgodey commented Feb 17, 2023

@Aditramesh This is a really old issue and I'm not sure how valid it is. Please check to see if money data types support all the same grouping types as number data types – if they don't, then you can work on it.

@Aditramesh
Copy link

@kgodey i can try doing that but if there is an issue which has higher priority and if you think I can solve it ,can you assign that to me ?

@kgodey
Copy link
Contributor Author

kgodey commented Feb 17, 2023

@Aditramesh I don't have any issues that I can think of right now. We will probably have more issues in around two weeks. The core team is busy with preparing for our initial release right now, so we haven't had much time to go through our issues recently.

@Aditramesh
Copy link

Understood,then I will try to work on this ,thanks @kgodey

@Anish9901
Copy link
Member

Unassigned due to inactivity.

@Aditramesh
Copy link

@Anish9901 i couldnt work much on this issue in the last two weeks but i have made some progress and i want to continue working on it,could you reassign this ?

@Anish9901
Copy link
Member

Please create a PR @Aditramesh and I'll reassign the issue to you.

@kgodey
Copy link
Contributor Author

kgodey commented Feb 2, 2024

Closing this, too old, requirements are out of date. We can create a new issue if we need this functionality in the future.

@kgodey kgodey closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

No branches or pull requests

6 participants