Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement grouping options for duration type #432

Closed
Tracked by #251
kgodey opened this issue Jul 18, 2021 · 4 comments
Closed
Tracked by #251

Implement grouping options for duration type #432

kgodey opened this issue Jul 18, 2021 · 4 comments
Labels
ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Milestone

Comments

@kgodey
Copy link
Contributor

kgodey commented Jul 18, 2021

Problem

We need to ensure that records that include columns of duration types support range based grouping just like Number types via the API. Please see #384 for the implementation details.

We should be able to reuse the implementation for Number types here.

This involves:

  • Implementing the grouping in the backend
  • Updating the /api/v0/databases/<id>/types/ endpoint to store available grouping on this type

Additional context

@shivansii
Copy link

hey! can I work on this issue?

@rajatvijay
Copy link
Contributor

@shivansii Sure, but note that since this does not have a help-wanted or good-first label, has a higher difficulty level.

@seancolsen
Copy link
Contributor

Unassigning due to inactivity

@kgodey
Copy link
Contributor Author

kgodey commented Feb 2, 2024

Closing this, too old, spec is likely wrong. We can create a new issue if we need this functionality in the future.

@kgodey kgodey closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

No branches or pull requests

6 participants