Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu to set cell value to NULL #930

Closed
seancolsen opened this issue Jan 3, 2022 · 3 comments · Fixed by #1215
Closed

Add context menu to set cell value to NULL #930

seancolsen opened this issue Jan 3, 2022 · 3 comments · Fixed by #1215
Assignees
Labels
affects: ux Related to user experience type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory

Comments

@seancolsen
Copy link
Contributor

seancolsen commented Jan 3, 2022

Current behavior

The user has no way to set a cell value to NULL.

Desired behavior

  1. Right click within a cell (or click-hold on a touch device).
  2. The browser's native context menu is suppressed.
  3. The cell is selected.
  4. A Mathesar-specific context menu appears.
  5. An item exists within the context menu labeled "Set to NULL".
  6. The menu entry is disabled if any of the following conditions are met:
    • The value is already NULL.
    • The column does not allow NULL.
  7. After the user clicks on the menu entry, the context menu disappears and Mathesar exhibits the same loading, success, and error behavior as when updating a value within a cell via typing new text and pressing Enter.

Notes

  • faBackspace, or faTimes would probably be acceptable icons to use in the menu.

Additional context

See also

Status

  • Blocked by Create Menu component #742, especially because we should rely on DropdownMenu functionality to implement the disabled feature.
@seancolsen seancolsen added type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory affects: ux Related to user experience needs: unblocking Blocked by other work labels Jan 3, 2022
@seancolsen
Copy link
Contributor Author

@ghislaineguerin the specs require the context menu entry to be "Set as NULL". That wording seems a bit awkward. Can we use "Set to NULL" instead?

@kgodey
Copy link
Contributor

kgodey commented Jan 3, 2022

@seancolsen I think it's fine to use "Set to NULL".

@seancolsen
Copy link
Contributor Author

Thanks @kgodey I've updated the issue description to reflect that adjustment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: ux Related to user experience type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants