Add keyboard shortcuts for setting a cell to NULL

[seancolsen]

Desired behavior

1. Select a cell.
2. Press Shift+Delete or Shift+Backspace.
3. The cell value will be set to NULL, with Mathesar exhibiting the same loading, success, and error behavior as it currently does when the user updates a value within a cell.

Notes

• The keyboard shortcuts should only be active when in select mode -- in edit mode there should not be any keyboard shortcuts for the user to set the cell value to NULL.

• If the column has a NOT NULL constraint, then an error toast message should show before a request is sent to the server, and no changes should be made.

  The toast message should read:

  <column_name> does not allow NULL.

  Within the toast message, the The column name should be stylized with the Identifier component and NULL should be stylized with the Null component.

• If the cell is already NULL, then no request should be sent to the server and no toast message should display.

Additional context

• NULL Values spec
• Discussion thread with some differing opinions about whether to use Delete or Shift+Delete.

See also

• Add context menu to set cell value to NULL #930

[nk183]

hi @seancolsen can I work on this

[kgodey]

Go ahead @nk183, thanks!

[seancolsen]

@nk183 Are you still working on this? We'll be working to close out this milestone soon, so we'll need to re-assign it to a core team member if we don't get a PR by 2022-04-19. Thanks.

[KasukabeDefenceForce]

hi @seancolsen can I work on this?

[Anish9901]

Assigned to you @AbhinavOhri. Thanks!

[KasukabeDefenceForce]

hi @Anish9901, I need some help on this. I have figured out the part of how to run the keyboard shortcut but I am unable to figure the file where I should make the desired changes and how to check whether the edit mode is enabled or not.

[KasukabeDefenceForce]

I have completed setting up the keyboard shortcut. But I could not figure it out the "NOT NULL constraint" segment , can you please guide me on that?

[pavish]

@AbhinavOhri Each Column instance has a nullable: boolean; property. If this is true, it means that the column accepts null as a valid value in the database. If it's false, it means that the column does not allow null.

Refer BaseColumn interface within mathesar_ui/src/api/types/tables/columns.ts/ for the type definitions. You can see that there's a method setNullabilityOfColumn in mathesar_ui/src/stores/table-data/columns.ts which sends requests to update this column property.

As part of this issue, if the column does not allow null, you should be showing a toast message and not send any requests. If it allows null, you can set the value in the cell to null and the requests should be handled by code that's already in place.

[ParthShirole]

Hey @Anish9901 Because it has been 2 weeks since an update, can I work on this?

[Anish9901]

Go ahead @ParthShirole

[KasukabeDefenceForce]

@Anish9901 I am still working on this. I am done setting up the keybind. I had some doubts about the not null constraint due to which I did not open a draft PR.

[Anish9901]

I had some doubts about the not null constraint due to which I did not open a draft PR.

I understand that @AbhinavOhri but opening a draft PR helps us to keep track of the progress and since there wasn't one I assumed that no progress was made. Anyway, feel free to open a PR.

[kgodey]

Assigned this back to @AbhinavOhri since there's a PR open.

[Fares-Basousy]

can i work on this

[rajatvijay]

@Fares-Basousy there's already a PR under review for this. Please choose another issue.

[Pulkit0729]

Hi, @Anish9901 can I work on this. as the last PR is in waiting for one month?

[Anish9901]

@Pulkit0729 I think @rajatvijay is taking care of this issue. You can look through other issues to fix.

[siddhiagarkar]

Hello @Anish9901
May I take up the task and work on this issue since it is pending yet?

[Anish9901]

Hey @siddhiagarkar, this issue is being worked on by one of our core team member and is therefore not up for grabs, please find other issues that might interest you.