-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix optionspattern #1113
fix optionspattern #1113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's do it! |
@mmatera I am now seeing this failure on master. I am not sure why we are not seeing it in CI:
|
That is one of the things I was trying to solve with this PR. I am going to investigate it. |
Ok. Then since it has been merged to master, let's comment out the failing test, and here you can continue to work on that and then merge in the remaining part. Sorry for hitting the merge button too soon. |
No description provided.