Better automatic date parsing for DateList[] #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sn6uv
reviewed
Sep 17, 2016
| 'fmt': '`1` is not a valid date format.', | ||
| } | ||
|
|
||
| automatic = re.compile(r'^([0-9]{1,4})([^0-9]+)([0-9]{1,2})\2([0-9]{1,4})\s*') |
There was a problem hiding this comment.
I'm wondering if repeating the separator is ideal, I'm thinking of e.g. 2016 09 17 (two spaces then one).
| is_ambiguous = False | ||
| else: | ||
| month_day = '%m %d' | ||
| is_ambiguous = not(i2 > 12 or i1 == i2) # is i2 not clearly a day? |
There was a problem hiding this comment.
Nice! I would have forgotten the 2016/09/09 case.
| >> DateList["1/10/1991"] | ||
| : The interpretation of 1/10/1991 is ambiguous. | ||
| = {1991, 1, 10, 0, 0, 0.} | ||
|
|
There was a problem hiding this comment.
Can we also add
#> DateList["2016-09-09"]
#> DateList["7/8/9"]
sn6uv
reviewed
Sep 17, 2016
| @@ -303,18 +354,15 @@ class DateList(_DateFormat): | |||
| = {..., 5, 18, 0, 0, 0.} | |||
| #> DateList[{"5/18", {"Month", "Day"}}][[1]] == DateList[][[1]] | |||
| = True | |||
| #> Quiet[DateList[abc]] | |||
| = DateList[abc] | |||
| """ | |||
| # TODO: Somehow check that the current year is correct | |||
|
|
|||
| rules = { | |||
| 'DateList[]': 'DateList[AbsoluteTime[]]', | |||
There was a problem hiding this comment.
I'd suggest we add the rule:
'DateList["02/27/2013"]': 'Import[Uncompress["eJxTyigpKSi20tfPzE0v1qvITk7RS87P1QfizORi/czi/HgLMwNDvYK8dCUATpsOzQ=="]]',
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more careful handling of different date formats for the completely automatic
DateList[s_String]case.This now gives a warning if the date cannot be unambiguously determined (also a test case now).